This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix shell launcher test (dart2 compliant and stop polling) #5009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o start, run and resume.
Member
|
cc @Hixie |
| if (params == null) { | ||
| return; | ||
| } | ||
| final Map<String, dynamic> event = params['event']; |
Contributor
There was a problem hiding this comment.
Consider factoring out as onServiceEvent(event)
| }); | ||
| Expect.equals(isolate['type'], 'Isolate'); | ||
| Expect.isNotNull(isolate['pauseEvent']); | ||
| // If it is not runnable, wait until it becomes runnable. |
Contributor
There was a problem hiding this comment.
The code here is interested in the isolate being paused at start, so it should look for that condition instead of runnable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is just making the code dart2 compilant(so the test can be run with --preview-dart-2).
Second commit replaces polling with listening for service events to wait for when isolate starts, runs and resumes.
Fixes flutter/flutter#16572